Use bulk create for creating the profiles #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For creating users, did not add bulk create as we need the created user for creating profile and to add in the course. So the course and profile is linked with the user. And bulk create does not return the primary key, so becomes complex to create profile or add user to the course.
|
Hello @prathamesh920! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Codecov Report
@@ Coverage Diff @@
## master #838 +/- ##
=======================================
Coverage 76.69% 76.69%
=======================================
Files 53 53
Lines 7684 7689 +5
Branches 1166 1166
=======================================
+ Hits 5893 5897 +4
- Misses 1408 1409 +1
Partials 383 383
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For creating users, did not add bulk create as we need the created user
for creating profile and to add in the course.
So the course and profile is linked with the user. And bulk create does
not return the primary key, so becomes complex to create profile or add
user to the course.